Update DDLm version to DDL2 1.8.9 equivalent#18
Merged
Conversation
added 5 commits
September 18, 2025 11:43
Contributor
|
The PR raises some merge conflicts (I do not have sufficient permissions to the repo to resolve them). Other than that, seems like a great improvement. |
vaitkus
reviewed
Sep 23, 2025
vaitkus
approved these changes
Sep 23, 2025
vaitkus
left a comment
vaitkus
left a comment
Contributor
There was a problem hiding this comment.
I have also tried validating the converted dictionary on my personal machine, everything works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes bring the DDLm translation up to date with cif_img_1.8.9 from the yayahjb repository. Two versions are now provided, one (
cif_img_expanded.dic) that preserves round-trip fidelity but fails strict style tests, andcif_img.dic, which removes all DDL2-specific tags and adjusts some values to conform to strict DDLm requirements. The expanded version is placed in a subdirectory so that it doesn't trigger testing.